Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support deletion of SCC Notification not in use in organization #196

Merged
merged 10 commits into from
May 3, 2024
Merged

feat: support deletion of SCC Notification not in use in organization #196

merged 10 commits into from
May 3, 2024

Conversation

daniel-cit
Copy link
Contributor

This PR supports the deletion of Security Command Center Notification not in use in organization that match a given pattern

@daniel-cit daniel-cit requested a review from a team as a code owner April 10, 2024 18:25
bharathkkb
bharathkkb approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit a few minor comments

modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
modules/project_cleanup/function_source/main.go Show resolved Hide resolved
modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
modules/project_cleanup/function_source/main.go Outdated Show resolved Hide resolved
@bharathkkb bharathkkb mentioned this pull request Apr 23, 2024
Merged
@daniel-cit daniel-cit requested a review from bharathkkb April 24, 2024 21:28
bharathkkb
bharathkkb approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-cit could you rebase?

@daniel-cit
Copy link
Contributor Author

@daniel-cit could you rebase?

Done

@daniel-cit
Copy link
Contributor Author

@bharathkkb build is green 🟢 :)

@apeabody apeabody merged commit b0e3ba0 into terraform-google-modules:master May 3, 2024
5 checks passed
@release-please release-please bot mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-cit @bharathkkb @apeabody